GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update ESLint to 7.17.0 by cjihrig · Pull Request #36726 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Jan 2, 2021

Copy link
Copy Markdown
Contributor

Update ESLint to 7.17.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@cjihrig
tools: update ESLint to 7.17.0
29c3b0d 
Update ESLint to 7.17.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 2, 2021
aduh95
aduh95 approved these changes Jan 2, 2021
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
yashLadha
yashLadha approved these changes Jan 3, 2021
View reviewed changes

@yashLadha yashLadha left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 3, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 3, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35229/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 3, 2021
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 4, 2021
@github-actions

github-actions Bot commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

Landed in 5ad67a7...64a4001
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Jan 4, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jan 4, 2021
@cjihrig @nodejs-github-bot
tools: update ESLint to 7.17.0
64a4001 
Update ESLint to 7.17.0

PR-URL: #36726
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
@cjihrig
cjihrig deleted the eslint branch January 4, 2021 19:05
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@cjihrig @danielleadams
tools: update ESLint to 7.17.0
4e0995b 
Update ESLint to 7.17.0

PR-URL: #36726
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 16, 2021
@cjihrig @targos
tools: update ESLint to 7.17.0
7babb64 
Update ESLint to 7.17.0

PR-URL: #36726
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@cjihrig @targos
tools: update ESLint to 7.17.0
613378d 
Update ESLint to 7.17.0

PR-URL: #36726
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@yashLadha yashLadha yashLadha approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@cjihrig @nodejs-github-bot @aduh95 @yashLadha
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.