GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: revise method text in async_hooks.md by Trott · Pull Request #36736 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. labels Jan 2, 2021
@RaisinTen

This comment has been minimized.

Sign in to view
@Trott
Trott force-pushed the ah-method branch from 1214258 to e95a87a Compare January 2, 2021 14:07
RaisinTen
RaisinTen reviewed Jan 2, 2021
View reviewed changes
Comment thread doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen reviewed Jan 2, 2021
View reviewed changes
Comment thread doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jan 5, 2021

Copy link
Copy Markdown
Member Author

@nodejs/documentation
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Jan 5, 2021
View reviewed changes
aymen94
aymen94 approved these changes Jan 7, 2021
View reviewed changes
HarshithaKP
HarshithaKP approved these changes Jan 7, 2021
View reviewed changes
@Trott
doc: revise method text in async_hooks.md
67c8e2b 
Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

PR-URL: nodejs#36736
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@Trott
Trott force-pushed the ah-method branch from ded2fbd to 67c8e2b Compare January 7, 2021 06:54
@Trott

Trott commented Jan 7, 2021

Copy link
Copy Markdown
Member Author

Landed in 67c8e2b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 67c8e2b into nodejs:master Jan 7, 2021
@Trott
Trott deleted the ah-method branch January 7, 2021 06:55
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Trott @danielleadams
doc: revise method text in async_hooks.md
757b966 
Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

PR-URL: #36736
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: revise method text in async_hooks.md
8620458 
Fix two typographical errors ("This methods") and general minor edits
around the use of the word "method" in async_hooks.md.

PR-URL: #36736
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaisinTen RaisinTen RaisinTen left review comments
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @RaisinTen @gireeshpunathil @aymen94 @HarshithaKP @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.