GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: reduce abbreviations in async_hooks.md by Trott · Pull Request #36737 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 2, 2021

Copy link
Copy Markdown
Member

Spell out or omit i.e. and e.g. as appropriate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. labels Jan 2, 2021
legendecas
legendecas approved these changes Jan 4, 2021
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Jan 4, 2021
View reviewed changes
@Trott
doc: reduce abbreviations in async_hooks.md
ddb1cba 
Spell out or omit _i.e._ and _e.g._ as appropriate.

PR-URL: nodejs#36737
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott
Trott force-pushed the ah-abbrev branch from 3ffc5c6 to ddb1cba Compare January 4, 2021 16:28
@Trott

Trott commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

Landed in ddb1cba
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit ddb1cba into nodejs:master Jan 4, 2021
@Trott
Trott deleted the ah-abbrev branch January 4, 2021 16:28
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Trott @danielleadams
doc: reduce abbreviations in async_hooks.md
fa54f01 
Spell out or omit _i.e._ and _e.g._ as appropriate.

PR-URL: #36737
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: reduce abbreviations in async_hooks.md
8bda9f4 
Spell out or omit _i.e._ and _e.g._ as appropriate.

PR-URL: #36737
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @gireeshpunathil @legendecas @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.