GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: simplify pull request template by Trott · Pull Request #36739 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 2, 2021

Copy link
Copy Markdown
Member

Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 2, 2021
himself65
himself65 approved these changes Jan 2, 2021
View reviewed changes
aduh95
aduh95 approved these changes Jan 2, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Jan 3, 2021
View reviewed changes
yashLadha
yashLadha approved these changes Jan 3, 2021
View reviewed changes
@yashLadha yashLadha added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 3, 2021
Trott added a commit to Trott/io.js that referenced this pull request Jan 4, 2021
@Trott
doc: simplify pull request template
551251e 
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

PR-URL: nodejs#36739
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
@Trott Trott closed this Jan 4, 2021
@Trott
Trott force-pushed the pr-template branch from 15fb986 to 551251e Compare January 4, 2021 16:26
@Trott

Trott commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

Landed in 551251e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the pr-template branch January 4, 2021 16:26
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Trott @danielleadams
doc: simplify pull request template
56c00d7 
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

PR-URL: #36739
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: simplify pull request template
1a65b44 
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.

PR-URL: #36739
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes
@himself65 himself65 himself65 approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@yashLadha yashLadha yashLadha approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @Lxxyx @himself65 @aduh95 @yashLadha @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.