GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — timers: refactor to use optional chaining by Lxxyx · Pull Request #36767 · nodejs/node

Conversation

@Lxxyx

@Lxxyx Lxxyx commented Jan 4, 2021

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout(). label Jan 4, 2021
@aduh95 aduh95 added the needs-benchmark-ci PRs that need a benchmark CI run. label Jan 4, 2021
@targos targos added dont-land-on-v10.x labels Jan 4, 2021
@aduh95

aduh95 commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/874/console

No regressions or improvements
                                                              confidence improvement accuracy (*)    (**)   (***)
 timers/timers-cancel-pooled.js n=5000000                                    -0.96 %       ±9.53% ±12.68% ±16.51%
 timers/timers-cancel-unpooled.js direction='end' n=1000000                   4.08 %       ±7.54% ±10.04% ±13.07%
 timers/timers-cancel-unpooled.js direction='start' n=1000000                -2.81 %       ±5.86%  ±7.80% ±10.16%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 3 comparisons, you can thus
expect the following amount of false-positive results:
  0.15 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.03 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 approved these changes Jan 5, 2021
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed needs-benchmark-ci PRs that need a benchmark CI run. labels Jan 5, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 5, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35327/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35332/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35333/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Lxxyx
timers: refactor to use optional chaining
738759a
@Lxxyx
Lxxyx force-pushed the timers-refactor-use-optional-chaining branch from fbf05e0 to 738759a Compare January 8, 2021 11:33
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35399/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35402/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell
jasnell approved these changes Jan 9, 2021
View reviewed changes
jasnell pushed a commit that referenced this pull request Jan 9, 2021
@Lxxyx @jasnell
timers: refactor to use optional chaining
d8f535b
PR-URL: #36767
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Jan 9, 2021

Copy link
Copy Markdown
Member

Landed in d8f535b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell jasnell closed this Jan 9, 2021
@Lxxyx
Lxxyx deleted the timers-refactor-use-optional-chaining branch January 11, 2021 10:43
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Lxxyx @danielleadams
timers: refactor to use optional chaining
8e8b16f
PR-URL: #36767
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
@mcollina

mcollina commented Apr 15, 2021

Copy link
Copy Markdown
Member

As part of #37937, I tracked down a regression introduced by this one.

With optional chaining:

Screenshot 2021-04-15 at 12 07 40

Without optional chaining:

Screenshot 2021-04-15 at 12 07 51

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcollina mcollina mentioned this pull request Apr 15, 2021
Revert "timers: refactor to use optional chaining" #38245
Closed
targos pushed a commit that referenced this pull request May 25, 2021
@Lxxyx @targos
timers: refactor to use optional chaining
779aa31
PR-URL: #36767
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added the dont-land-on-v14.x label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Lxxyx @aduh95 @nodejs-github-bot @jasnell @mcollina @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.