GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify when messageerror is emitted by jasnell · Pull Request #36780 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member

Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell [email protected]
/cc @addaleax @naz

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
naz reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@jasnell
doc: clarify when messageerror is emitted
c09df40 
Adapting addaleax's explanation from the issue.

Fixes: nodejs#36333
Signed-off-by: James M Snell <[email protected]>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. worker Issues and PRs related to the worker_threads module and Worker API. labels Jan 4, 2021
addaleax
addaleax approved these changes Jan 4, 2021
View reviewed changes
juanarbol
juanarbol approved these changes Jan 5, 2021
View reviewed changes
RaisinTen
RaisinTen reviewed Jan 5, 2021
View reviewed changes
Comment thread doc/api/worker_threads.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell @RaisinTen
[squash] nit
2b863d1 
Co-authored-by: Darshan Sen <[email protected]>
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Jan 6, 2021
@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

Landed in 9ac4047
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
@jasnell
doc: clarify when messageerror is emitted
9ac4047 
Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36780
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
doc: clarify when messageerror is emitted
b4091ea 
Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36780
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: clarify when messageerror is emitted
a800b5b 
Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36780
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaisinTen RaisinTen RaisinTen left review comments
@addaleax addaleax addaleax approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: unclear conditions under which Worker's 'messageerror' is emmited

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jasnell @addaleax @juanarbol @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.