GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: avoid memory leak warning in async_hooks example by jasnell · Pull Request #36783 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member

The example lead to an event emitter memory leak warning previously.

Fixes: #35952
Signed-off-by: James M Snell [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell
doc: avoid memory leak warning in async_hooks example
e430845 
Fixes: nodejs#35952
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. labels Jan 4, 2021
Flarna
Flarna approved these changes Jan 4, 2021
View reviewed changes
juanarbol
juanarbol approved these changes Jan 5, 2021
View reviewed changes
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Jan 6, 2021
@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

This shouldn't need to wait the full time to land. Please 👍🏻 to fast track
Flarna reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Flarna Flarna added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2021
@jasnell jasnell removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2021
@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

Landed in 3518919
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
@jasnell
doc: avoid memory leak warning in async_hooks example
3518919 
Fixes: #35952

PR-URL: #36783
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
doc: avoid memory leak warning in async_hooks example
61b0393 
Fixes: #35952

PR-URL: #36783
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: avoid memory leak warning in async_hooks example
e973bdc 
Fixes: #35952

PR-URL: #36783
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanarbol juanarbol juanarbol approved these changes
@Flarna Flarna Flarna approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: WorkerPool async_hooks example warns about max listeners

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jasnell @juanarbol @Flarna @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.