GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — process: passing -1 to setuid/setgid should not abort by jasnell · Pull Request #36786 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member

Fixes: #32750
Signed-off-by: James M Snell [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell
process: passing -1 to setuid/setgid should not abort
30ecea9 
Fixes: nodejs#32750
Signed-off-by: James M Snell <[email protected]>
@jasnell

jasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

Alternative to the stalled #32841
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added process Issues and PRs related to the process subsystem. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 4, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 4, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35249/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jan 4, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35316/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Jan 6, 2021
View reviewed changes
Comment thread lib/internal/bootstrap/switches/does_own_process_state.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell @targos
[Squash] ...
02b9fac 
Co-authored-by: Michaël Zasso <[email protected]>
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 6, 2021
HarshithaKP
HarshithaKP approved these changes Jan 6, 2021
View reviewed changes

@HarshithaKP HarshithaKP left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the suggestion was to makes changes in C++ source code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

This comment has been minimized.

Sign in to view
antsmartian
antsmartian approved these changes Jan 7, 2021
View reviewed changes
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 8, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 8, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35385/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request Jan 9, 2021
@jasnell
process: passing -1 to setuid/setgid should not abort
421279b 
Fixes: #32750
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36786
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@jasnell

jasnell commented Jan 9, 2021

Copy link
Copy Markdown
Member Author

Landed in 421279b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 9, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
process: passing -1 to setuid/setgid should not abort
94afc3e 
Fixes: #32750
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36786
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
@HarshithaKP HarshithaKP mentioned this pull request Jan 13, 2021
lib: coerce -0 into 0 for process APIs #32841
Closed
1 of 4 tasks
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
process: passing -1 to setuid/setgid should not abort
4305759 
Fixes: #32750
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36786
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
tniessen added a commit to tniessen/node that referenced this pull request Oct 7, 2022
@tniessen
process: fix uid/gid validation to avoid crash
37479e9 
id |= 0 turns unsigned 32-bit integer values exceeding the unsigned
31-bit range into negative integers, causing a crash. Use id >>>= 0
instead, which works properly for all unsigned 32-bit integers.

Refs: nodejs#36786
@tniessen tniessen mentioned this pull request Oct 7, 2022
process: fix uid/gid validation to avoid crash #44910
Merged
nodejs-github-bot pushed a commit that referenced this pull request Oct 10, 2022
@tniessen
process: fix uid/gid validation to avoid crash
997334c 
id |= 0 turns unsigned 32-bit integer values exceeding the unsigned
31-bit range into negative integers, causing a crash. Use id >>>= 0
instead, which works properly for all unsigned 32-bit integers.

Refs: #36786
PR-URL: #44910
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@tniessen @danielleadams
process: fix uid/gid validation to avoid crash
803fbfb 
id |= 0 turns unsigned 32-bit integer values exceeding the unsigned
31-bit range into negative integers, causing a crash. Use id >>>= 0
instead, which works properly for all unsigned 32-bit integers.

Refs: #36786
PR-URL: #44910
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes
+2 more reviewers
@antsmartian antsmartian antsmartian approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

process.setuid results in an abort

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jasnell @nodejs-github-bot @antsmartian @targos @aduh95 @HarshithaKP
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.