GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: guard large string decoder allocation by targos · Pull Request #36795 · nodejs/node

Conversation

@targos

@targos targos commented Jan 5, 2021

Copy link
Copy Markdown
Member

Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 5, 2021
@targos targos mentioned this pull request Jan 5, 2021
test-string-decoder failing regularly on arm #36792
Closed
@targos targos added fast-track PRs proposed for a shorter-than-standard waiting period before landing. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 5, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 5, 2021
@targos

targos commented Jan 5, 2021

Copy link
Copy Markdown
Member Author

👍 to fast-track and make ARM CI green.
gireeshpunathil, PoojaDurgad, and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35268/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Jan 5, 2021
View reviewed changes
PoojaDurgad
PoojaDurgad approved these changes Jan 5, 2021
View reviewed changes
aduh95
aduh95 approved these changes Jan 5, 2021
View reviewed changes
@targos @aduh95
test: guard large string decoder allocation
e5b8c61 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: nodejs#36792

PR-URL: nodejs#36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95
aduh95 force-pushed the fix-36792 branch from a262a45 to e5b8c61 Compare January 5, 2021 08:40
@aduh95

aduh95 commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Landed in e5b8c61
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit e5b8c61 into nodejs:master Jan 5, 2021
@targos
targos deleted the fix-36792 branch January 5, 2021 08:43
@mhdawson

mhdawson commented Jan 5, 2021

Copy link
Copy Markdown
Member

@targos thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@targos @danielleadams
test: guard large string decoder allocation
9b7d2c2 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos added a commit that referenced this pull request May 25, 2021
@targos
test: guard large string decoder allocation
7f0d5d3 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos added a commit that referenced this pull request Jun 5, 2021
@targos
test: guard large string decoder allocation
c9135b8 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos added a commit that referenced this pull request Jun 11, 2021
@targos
test: guard large string decoder allocation
c34de75 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@StefanStojanovic StefanStojanovic mentioned this pull request Jul 12, 2023
test: fix flaky test-string-decode.js on x86 #48750
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-string-decoder failing regularly on arm

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @nodejs-github-bot @aduh95 @mhdawson @gireeshpunathil @PoojaDurgad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.