GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: fix http2 benchmarks by Trott · Pull Request #36871 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 10, 2021

Copy link
Copy Markdown
Member

Fixes: #36746

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. http2 Issues and PRs related to the http2 subsystem. labels Jan 10, 2021
@Trott Trott mentioned this pull request Jan 10, 2021
http2 benchmark seems broken #36746
Closed
aduh95
aduh95 approved these changes Jan 10, 2021
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 10, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 10, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35424/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jan 10, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Welp...I tried running the http2 benchmarks with these changes and I still got EADDRNOTAVAIL...so the new theory is...uh...working on it....
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 10, 2021
@Trott
Trott force-pushed the fix-http2-benchmarks branch from c78d88f to c89052d Compare January 10, 2021 19:02
@Trott

Trott commented Jan 10, 2021

Copy link
Copy Markdown
Member Author

Looks like the http2 benchmarker emits errors on connection but the http and https benchmarkers swallow them. I've added a commit to swallow connection errors on http2, and will run the benchmarks now to see if that causes any surprising results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jan 10, 2021

Copy link
Copy Markdown
Member Author

Looks like the http2 benchmarker emits errors on connection but the http and https benchmarkers swallow them. I've added a commit to swallow connection errors on http2, and will run the benchmarks now to see if that causes any surprising results.

That seems to be working.
aduh95 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35430/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 10, 2021 •
edited by Trott
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35431/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott mentioned this pull request Jan 11, 2021
lib: string indexOf to use primordials for http2/compat.js #36679
Closed
2 tasks done
@Trott

Trott commented Jan 11, 2021

Copy link
Copy Markdown
Member Author

I'd like to fast-track this so I can follow up on #36679 (comment). Please 👍 here to fast-track.
gireeshpunathil, PoojaDurgad, and yashLadha reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 11, 2021
gireeshpunathil
gireeshpunathil approved these changes Jan 11, 2021
View reviewed changes
@Trott Trott closed this Jan 11, 2021
@Trott
Trott force-pushed the fix-http2-benchmarks branch from c89052d to 1c4fa9a Compare January 11, 2021 04:27
@Trott

Trott commented Jan 11, 2021

Copy link
Copy Markdown
Member Author

Landed in 1c4fa9a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the fix-http2-benchmarks branch January 11, 2021 04:27
@Trott
Trott merged commit 1c4fa9a into nodejs:master Jan 11, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Trott @danielleadams
benchmark: fix http2 benchmarks
3ca7a78 
Fixes: #36746

PR-URL: #36871
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
v15.6.0 proposal #36889
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
benchmark: fix http2 benchmarks
c22efc5 
Fixes: #36746

PR-URL: #36871
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@Linkgoron Linkgoron mentioned this pull request May 24, 2021
Benchmark machine maintenance nodejs/build#2656
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. http2 Issues and PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http2 benchmark seems broken

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @nodejs-github-bot @gireeshpunathil @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.