GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — crypto: fix WebCrypto import of RSA-PSS keys by tniessen · Pull Request #36877 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Jan 11, 2021

Copy link
Copy Markdown
Member

This patch changes GetRsaKeyDetail to work in older supported versions of OpenSSL. The added test case fails CI without this patch.

I assume the WebCrypto implementation also does not handle imported RSASSA-PSS-params correctly, but it is out of scope for this PR to fix that. Last time I checked, OpenSSL made that step difficult.

Refs: openssl/openssl#10217
Refs: #36188

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen tniessen added the crypto Issues and PRs related to the crypto subsystem. label Jan 11, 2021
@tniessen
tniessen requested a review from jasnell January 11, 2021 14:20
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 11, 2021
@tniessen tniessen mentioned this pull request Jan 11, 2021
crypto: add keyObject.asymmetricKeyDetails for asymmetric keys #36188
Closed
4 tasks done
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 11, 2021
jasnell
jasnell approved these changes Jan 11, 2021
View reviewed changes
panva
panva approved these changes Jan 11, 2021
View reviewed changes
richardlau
richardlau approved these changes Jan 11, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Jan 11, 2021
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The linter seems to be complaining about the test though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen tniessen removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 11, 2021
@tniessen
tniessen force-pushed the webcrypto-pss-fips branch from a5e3daf to d39102e Compare January 11, 2021 14:25
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 11, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 11, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@tniessen
crypto: fix WebCrypto import of RSA-PSS keys
1a74096 
This patch changes GetRsaKeyDetail to work in older supported versions
of OpenSSL.

Refs: openssl/openssl#10217
@tniessen
tniessen force-pushed the webcrypto-pss-fips branch from d39102e to 1a74096 Compare January 11, 2021 18:08
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35451/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 11, 2021
panva
panva approved these changes Jan 13, 2021
View reviewed changes
panva pushed a commit that referenced this pull request Jan 13, 2021
@tniessen @panva
crypto: fix WebCrypto import of RSA-PSS keys
6a7eb32 
This patch changes GetRsaKeyDetail to work in older supported versions
of OpenSSL.

Refs: openssl/openssl#10217

PR-URL: #36877
Refs: #36188
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@panva

panva commented Jan 13, 2021

Copy link
Copy Markdown
Member

Landed in 6a7eb32
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva closed this Jan 13, 2021
@tniessen tniessen removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 14, 2021
@tniessen
tniessen deleted the webcrypto-pss-fips branch January 15, 2021 17:14
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@tniessen @ruyadorno
crypto: fix WebCrypto import of RSA-PSS keys
0398167 
This patch changes GetRsaKeyDetail to work in older supported versions
of OpenSSL.

Refs: openssl/openssl#10217

PR-URL: #36877
Refs: #36188
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
v15.7.0 proposal #37020
Merged
@targos targos added the dont-land-on-v14.x label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tniessen @nodejs-github-bot @panva @jasnell @cjihrig @richardlau @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.