GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: update fs.l/statSync API history for throwIfNoEntry by amcasey · Pull Request #36882 · nodejs/node

Conversation

@amcasey

@amcasey amcasey commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

As suggested here, now that there's a version number, the history in the API document can be updated to reflect this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
merceyz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@amcasey
chore: update fs.l/statSync API history for throwIfNoEntry
e295f41
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module. labels Jan 12, 2021
@amcasey

amcasey commented Jan 12, 2021

Copy link
Copy Markdown
Contributor Author

FYI @merceyz
merceyz reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jan 12, 2021
View reviewed changes
@aduh95 aduh95 added the backport-requested-v14.x label Jan 12, 2021
mscdex
mscdex reviewed Jan 12, 2021
View reviewed changes
Comment thread doc/api/fs.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@amcasey
Refine history description
edd034b
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 12, 2021
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 12, 2021
jasnell
jasnell approved these changes Jan 12, 2021
View reviewed changes
@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 12, 2021
@aduh95

aduh95 commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

@jasnell I removed the request-ci label because this is a doc-only change.
jasnell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Jan 14, 2021

Copy link
Copy Markdown
Member

Landed in 8f32733
amcasey reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 14, 2021
jasnell pushed a commit that referenced this pull request Jan 14, 2021
@amcasey @jasnell
doc: update fs.l/statSync API history for throwIfNoEntry
8f32733 
PR-URL: #36882
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 14, 2021
@amcasey @aduh95
doc: update fs.l/statSync API history for throwIfNoEntry
8b03585 
PR-URL: nodejs#36882
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request Jan 14, 2021
[v14.x Backport] lib: add throws option to fs.f/l/statSync #36921
Closed
@aduh95 aduh95 added backport-open-v14.x and removed backport-requested-v14.x labels Jan 14, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@amcasey @ruyadorno
doc: update fs.l/statSync API history for throwIfNoEntry
82eccdd 
PR-URL: #36882
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
v15.7.0 proposal #37020
Merged
targos pushed a commit that referenced this pull request Apr 26, 2021
@amcasey @targos
doc: update fs.l/statSync API history for throwIfNoEntry
5a3e12b 
PR-URL: #36882
Backport-PR-URL: #36921
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added backported-to-v14.x and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-open-v14.x labels Apr 26, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@mscdex mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@amcasey @aduh95 @jasnell @mscdex @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.