GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — url: align url format behavior with browsers by Lxxyx · Pull Request #36903 · nodejs/node

Conversation

@Lxxyx

@Lxxyx Lxxyx commented Jan 13, 2021

Copy link
Copy Markdown
Member

Fixes: #36887

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
targos
targos reviewed Jan 13, 2021
View reviewed changes
Comment thread test/parallel/test-url-override-hostname.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
targos
targos reviewed Jan 13, 2021
View reviewed changes
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/url.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx
Lxxyx force-pushed the fix-url-format branch from 15ed206 to 4d4c8a4 Compare January 13, 2021 10:05
@Lxxyx
Lxxyx requested a review from targos January 13, 2021 10:07
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 13, 2021
targos
targos approved these changes Jan 13, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35498/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZYSzys
ZYSzys approved these changes Jan 13, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35503/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35506/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanarbol
juanarbol approved these changes Jan 13, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35514/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35518/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell
jasnell requested a review from addaleax January 13, 2021 14:26
RaisinTen
RaisinTen reviewed Jan 13, 2021
View reviewed changes
Comment thread test/parallel/test-whatwg-url-override-hostname.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Jan 13, 2021
View reviewed changes
Comment thread test/parallel/test-whatwg-url-override-hostname.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Jan 13, 2021
View reviewed changes
@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 13, 2021
TimothyGu
TimothyGu approved these changes Jan 14, 2021
View reviewed changes
@Lxxyx
Lxxyx force-pushed the fix-url-format branch from 4d4c8a4 to 99ee23d Compare January 14, 2021 04:55
@nodejs-github-bot

nodejs-github-bot commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35552/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jan 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35554/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
watilde
watilde approved these changes Jan 15, 2021
View reviewed changes
@Lxxyx @aduh95
url: align url format behavior with browsers
9566083 
Fixes: nodejs#36887

PR-URL: nodejs#36903
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@aduh95
aduh95 force-pushed the fix-url-format branch from 99ee23d to 9566083 Compare January 18, 2021 10:50
@aduh95

aduh95 commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Landed in 9566083
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 closed this Jan 18, 2021
@Lxxyx
Lxxyx deleted the fix-url-format branch January 18, 2021 11:01
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@Lxxyx @ruyadorno
url: align url format behavior with browsers
889654d 
Fixes: #36887

PR-URL: #36903
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
v15.7.0 proposal #37020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Lxxyx @targos
url: align url format behavior with browsers
d13fc6e 
Fixes: #36887

PR-URL: #36903
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments
@RaisinTen RaisinTen RaisinTen left review comments
@addaleax addaleax addaleax approved these changes
@watilde watilde watilde approved these changes
@juanarbol juanarbol juanarbol approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes
+2 more reviewers
@TimothyGu TimothyGu TimothyGu approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

URL href mismatch from browsers

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@Lxxyx @nodejs-github-bot @aduh95 @jasnell @addaleax @TimothyGu @watilde @targos @juanarbol @ZYSzys @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.