GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix percentile range in perf_hooks.md by RaisinTen · Pull Request #36938 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Jan 15, 2021

Copy link
Copy Markdown
Member

The value accepted by histogram.percentile may be below 1 too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. labels Jan 15, 2021
jasnell
jasnell approved these changes Jan 15, 2021
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 15, 2021
aduh95
aduh95 approved these changes Jan 16, 2021
View reviewed changes
@RaisinTen @aduh95
doc: fix percentile range in perf_hooks.md
b003643 
The value accepted by histogram.percentile may be below 1 too.

PR-URL: nodejs#36938
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95
aduh95 force-pushed the doc/fix-percentile-range-in-perf_hooks.md branch from 563bd54 to b003643 Compare January 18, 2021 11:04
@aduh95

aduh95 commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Landed in b003643
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit b003643 into nodejs:master Jan 18, 2021
@RaisinTen
RaisinTen deleted the doc/fix-percentile-range-in-perf_hooks.md branch January 18, 2021 11:22
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@RaisinTen @ruyadorno
doc: fix percentile range in perf_hooks.md
af0f0a0 
The value accepted by histogram.percentile may be below 1 too.

PR-URL: #36938
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
v15.7.0 proposal #37020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
doc: fix percentile range in perf_hooks.md
d43492e 
The value accepted by histogram.percentile may be below 1 too.

PR-URL: #36938
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RaisinTen @aduh95 @jasnell @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.