GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: improve AsyncLocalStorage introduction by brillout · Pull Request #36946 · nodejs/node

Conversation

brillout commented Jan 15, 2021

Copy link

Copy Markdown

Contributor

I've tried to comply to the contributing guidlines although I skimed over some of it; hopefully I didn't miss anything.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          doc: improve AsyncLocalStorage introduction

e3ef260

nodejs-github-bot added async_hooks

Issues and PRs related to the async hooks subsystem.

doc Issues and PRs related to Node.js documentation. labels

Jan 15, 2021

vdeturckheim suggested changes

Jan 15, 2021

View reviewed changes

vdeturckheim left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally LGTM, @puzpuzpuz @Flarna @Qard maybe you want to take a look :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          [review] add title

af8e514

puzpuzpuz reviewed

Jan 15, 2021

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

puzpuzpuz reviewed

Jan 15, 2021

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

puzpuzpuz reviewed

Jan 15, 2021

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Qard requested changes

Jan 15, 2021

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

brillout added 2 commits

January 18, 2021 22:25


          [review] typo

fdf72e7


          [review] remove information that are unnecessary, prone to become fal…

a8db18c

…se, or prone to misinterpretationtion

brillout commented Jan 18, 2021

Copy link

Copy Markdown

Contributor Author

@vdeturckheim
@Qard
@puzpuzpuz

I rewrote and shorten the paragraph; I believe it resolves all issues.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vdeturckheim approved these changes

Jan 18, 2021

View reviewed changes

vdeturckheim left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

puzpuzpuz reviewed

Jan 19, 2021

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          [review] implement @puzpuzpuz's feedback

c26fe60

puzpuzpuz self-requested a review

January 19, 2021 13:14

puzpuzpuz approved these changes

Jan 19, 2021

View reviewed changes

Qard reviewed

Jan 19, 2021

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          [review] emphasis significance of performance

2fe233d

Qard approved these changes

Jan 22, 2021

View reviewed changes

jasnell approved these changes

Jan 25, 2021

View reviewed changes

jasnell commented Jan 25, 2021

Copy link

Copy Markdown

Member

Landed in 63d978c

vdeturckheim, brillout, Qard, and zapmal reacted with rocket emoji

All reactions

🚀 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell closed this

Jan 25, 2021

jasnell pushed a commit that referenced this pull request

Jan 25, 2021


          doc: improve AsyncLocalStorage introduction

63d978c

PR-URL: #36946
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos pushed a commit that referenced this pull request

Feb 2, 2021


          doc: improve AsyncLocalStorage introduction

c79688f

PR-URL: #36946
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request

Feb 2, 2021

v15.8.0 release proposal #37183

Merged

targos pushed a commit that referenced this pull request

May 1, 2021


          doc: improve AsyncLocalStorage introduction

49f1374

PR-URL: #36946
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: James M Snell <[email protected]>

danielleadams mentioned this pull request

May 3, 2021

v14.17.0 proposal #38507

Merged

Reviewers

Qard

Qard approved these changes

jasnell

jasnell approved these changes

+2 more reviewers

puzpuzpuz

puzpuzpuz approved these changes

vdeturckheim

vdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks

Issues and PRs related to the async hooks subsystem.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.