GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: increase timeout on ASAN Action by aduh95 · Pull Request #37007 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
test: increase timeout on ASAN Action
9acd2d7 
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 20, 2021
ttzztztz
ttzztztz approved these changes Jan 23, 2021
View reviewed changes

@ttzztztz ttzztztz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott
Trott reviewed Jan 24, 2021
View reviewed changes
Comment thread .github/workflows/test-asan.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jan 24, 2021
View reviewed changes
@aduh95
fixup! test: increase timeout on ASAN Action
d0e82dd
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 24, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35711/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jan 24, 2021
View reviewed changes
jasnell pushed a commit that referenced this pull request Jan 24, 2021
@aduh95 @jasnell
test: increase timeout on ASAN Action
90cae3a 
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Jan 24, 2021

Copy link
Copy Markdown
Member

Landed in 90cae3a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 24, 2021
@aduh95
aduh95 deleted the asan-gh-action-timeout branch January 24, 2021 22:43
targos pushed a commit that referenced this pull request Feb 2, 2021
@aduh95 @targos
test: increase timeout on ASAN Action
2135618 
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
v15.8.0 release proposal #37183
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@aduh95 @targos
test: increase timeout on ASAN Action
c21c273 
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
test: increase timeout on ASAN Action
e78b5d6 
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
test: increase timeout on ASAN Action
ac446de 
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
test: increase timeout on ASAN Action
d85b70f 
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
+1 more reviewer
@ttzztztz ttzztztz ttzztztz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @jasnell @Trott @ttzztztz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.