GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add tests for mode passed as an options object in mkdir and mkdirSync by RaisinTen · Pull Request #37008 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Jan 20, 2021

Copy link
Copy Markdown
Member

This also adds coverage for mkdirSync inside the conditional where
options.mode is not undefined.

Refs: https://coverage.nodejs.org/coverage-e3e054d020ee5ef6/lib/fs.js.html#L1023

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen
test: add tests for mode passed as an options object in mkdir and mkd…
75df964 
…irSync

This also adds coverage for mkdirSync inside the conditional where
options.mode is not undefined.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 20, 2021
lpinca
lpinca approved these changes Jan 20, 2021
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35697/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 23, 2021
Trott
Trott approved these changes Jan 23, 2021
View reviewed changes
Trott pushed a commit that referenced this pull request Jan 23, 2021
@RaisinTen @Trott
test: test mode passed as an options object in mkdir/mkdirSync
3f4bfef 
Add tests for mode passed as an options object in fs.mkdir() and
fs.mkdirSync().

This also adds coverage for mkdirSync() inside the conditional where
options.mode is not undefined.

PR-URL: #37008
Refs: https://coverage.nodejs.org/coverage-e3e054d020ee5ef6/lib/fs.js.html#L1023
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott

Trott commented Jan 23, 2021

Copy link
Copy Markdown
Member

Landed in 3f4bfef
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Jan 23, 2021
@RaisinTen
RaisinTen deleted the test/add-test-for-mode-passed-as-options branch January 24, 2021 13:19
targos pushed a commit that referenced this pull request Feb 2, 2021
@RaisinTen @targos
test: test mode passed as an options object in mkdir/mkdirSync
36930e4 
Add tests for mode passed as an options object in fs.mkdir() and
fs.mkdirSync().

This also adds coverage for mkdirSync() inside the conditional where
options.mode is not undefined.

PR-URL: #37008
Refs: https://coverage.nodejs.org/coverage-e3e054d020ee5ef6/lib/fs.js.html#L1023
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
v15.8.0 release proposal #37183
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
test: test mode passed as an options object in mkdir/mkdirSync
0e1963c 
Add tests for mode passed as an options object in fs.mkdir() and
fs.mkdirSync().

This also adds coverage for mkdirSync() inside the conditional where
options.mode is not undefined.

PR-URL: #37008
Refs: https://coverage.nodejs.org/coverage-e3e054d020ee5ef6/lib/fs.js.html#L1023
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RaisinTen @nodejs-github-bot @Trott @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.