GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: process.nextTick for beforeExit case by ttzztztz · Pull Request #37012 · nodejs/node

Conversation

@ttzztztz

@ttzztztz ttzztztz commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

This is a test for test case test/parallel/test-process-beforeexit.js to test the behavior of process.nextTick with process.on('beforeExit', ()=>{}) event

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ttzztztz
test: process.nextTick for before exit
f4c0e6c
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 21, 2021
aduh95
aduh95 approved these changes Jan 21, 2021
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Flarna
Flarna approved these changes Jan 21, 2021
View reviewed changes
@Flarna Flarna added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 21, 2021
juanarbol
juanarbol approved these changes Jan 21, 2021
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttzztztz Thank you! This is amazing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Jan 22, 2021
View reviewed changes
Comment thread test/parallel/test-process-beforeexit.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ttzztztz @lpinca
Update test/parallel/test-process-beforeexit.js
d057220 
Co-authored-by: Luigi Pinca <[email protected]>
Trott
Trott reviewed Jan 24, 2021
View reviewed changes
Comment thread test/parallel/test-process-beforeexit.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Trott
Trott approved these changes Jan 24, 2021
View reviewed changes
@Trott

Trott commented Jan 24, 2021

Copy link
Copy Markdown
Member

Welcome @ttzztztz and thanks for the pull request!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
jasnell
jasnell approved these changes Jan 24, 2021
View reviewed changes
ttzztztz added 2 commits January 25, 2021 15:04
@ttzztztz
chore: comments for the extra unit test
c19b457
@ttzztztz
fix: linter issues
894f133
@nodejs-github-bot

This comment has been minimized.

Sign in to view
aduh95
aduh95 reviewed Jan 25, 2021
View reviewed changes
Comment thread test/parallel/test-process-beforeexit.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-process-beforeexit.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ttzztztz
chore: comment
f6d0643
aduh95
aduh95 reviewed Jan 25, 2021
View reviewed changes
Comment thread test/parallel/test-process-beforeexit.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-process-beforeexit.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ttzztztz
comment: nit
6fbf936
@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35726/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Jan 25, 2021
@ttzztztz @jasnell
test: process.nextTick for before exit
1377163 
PR-URL: #37012
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Jan 25, 2021

Copy link
Copy Markdown
Member

Landed in 1377163
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 25, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
@ttzztztz @targos
test: process.nextTick for before exit
94204f7 
PR-URL: #37012
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
v15.8.0 release proposal #37183
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@ttzztztz @targos
test: process.nextTick for before exit
456fd75 
PR-URL: #37012
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@juanarbol juanarbol juanarbol approved these changes
@Flarna Flarna Flarna approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ttzztztz @nodejs-github-bot @Trott @jasnell @lpinca @aduh95 @juanarbol @Flarna
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.