GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve coverage of `SourceTextModule` getters by juanarbol · Pull Request #37013 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Jan 21, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 21, 2021
RaisinTen
RaisinTen reviewed Jan 21, 2021
View reviewed changes
Comment thread test/parallel/test-vm-module-errors.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen reviewed Jan 21, 2021
View reviewed changes
Comment thread test/parallel/test-vm-module-errors.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen reviewed Jan 21, 2021
View reviewed changes
Comment thread test/parallel/test-vm-module-errors.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen reviewed Jan 21, 2021
View reviewed changes
Comment thread test/parallel/test-vm-module-errors.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol
juanarbol force-pushed the juanarbol/sourcetextmodule-code-coverage branch from 5a34564 to feca4cf Compare January 21, 2021 22:03
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35670/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Jan 22, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35678/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jan 22, 2021
View reviewed changes
@juanarbol juanarbol added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 23, 2021
Trott
Trott approved these changes Jan 24, 2021
View reviewed changes
@Trott

Trott commented Jan 24, 2021

Copy link
Copy Markdown
Member

Landed in 6b62f70
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Jan 24, 2021
@Trott
Trott force-pushed the juanarbol/sourcetextmodule-code-coverage branch from feca4cf to 6b62f70 Compare January 24, 2021 15:33
@Trott
Trott merged commit 6b62f70 into nodejs:master Jan 24, 2021
@juanarbol
juanarbol deleted the juanarbol/sourcetextmodule-code-coverage branch January 29, 2021 18:14
targos pushed a commit that referenced this pull request Feb 2, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
de6dca1 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
v15.8.0 release proposal #37183
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
717f0bd 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
d9293a3 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
de6b446 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@juanarbol @targos
test: improve coverage of SourceTextModule getters
836fba5 
PR-URL: #37013
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@juanarbol @nodejs-github-bot @Trott @lpinca @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.