GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: make output RFC 4180 compliant by tniessen · Pull Request #37038 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Jan 23, 2021

Copy link
Copy Markdown
Member

I had trouble importing the generated CSV into other software because it doesn't conform to RFC 4180, the de facto standard for CSV.

Relevant information from the RFC:

Spaces are considered part of a field and should not be ignored. [...] If fields are not enclosed with double quotes, then double quotes may not appear inside the fields.

Since spaces are considered part of a field, we end up with fields of the form ' "foo"' (note the space in front of the quoted value), and now the quote isn't the first character within the field, so it violates the RFC.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen
benchmark: make output RFC 4180 compliant
d35a64d
@tniessen tniessen added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Jan 23, 2021
RaisinTen
RaisinTen approved these changes Jan 23, 2021
View reviewed changes
@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 23, 2021
jasnell
jasnell approved these changes Jan 23, 2021
View reviewed changes
Trott
Trott approved these changes Jan 23, 2021
View reviewed changes
lpinca
lpinca approved these changes Jan 23, 2021
View reviewed changes
aduh95
aduh95 approved these changes Jan 24, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Jan 24, 2021
View reviewed changes
@jasnell

jasnell commented Jan 25, 2021

Copy link
Copy Markdown
Member

Just noting for whomever lands this... there don't appear to be any CI tests covering compare.js so a full CI run would be pointless.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Jan 25, 2021

Copy link
Copy Markdown
Member

There's no reason for this to wait the full minimum time to land. Please 👍🏻 to fast-track
RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 25, 2021
@jasnell

jasnell commented Jan 25, 2021

Copy link
Copy Markdown
Member

Landed in 9da3f21
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 25, 2021
jasnell pushed a commit that referenced this pull request Jan 25, 2021
@tniessen @jasnell
benchmark: make output RFC 4180 compliant
9da3f21 
PR-URL: #37038
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@tniessen
tniessen deleted the benchmark-make-output-rfc-4180-compliant branch January 25, 2021 17:10
@tniessen tniessen removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 25, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
@tniessen @targos
benchmark: make output RFC 4180 compliant
ec22756 
PR-URL: #37038
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
v15.8.0 release proposal #37183
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@tniessen @targos
benchmark: make output RFC 4180 compliant
4318e70 
PR-URL: #37038
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tniessen @jasnell @Trott @lpinca @cjihrig @aduh95 @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.