GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — doc: update Buffer encoding option count by davecardwell · Pull Request #37102 · nodejs/node Conversation
Contributor
#36952 added the Easier to just remove the count of options so it doesn’t need to be updated to four, five, etc. in the future.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsnodejs#36952 added the `base64url` encoding option. Easier to just remove the count of options so it doesn’t need to be updated to four, five, etc. in the future.
RaisinTen
approved these changes
panva
approved these changes
aduh95
approved these changes
jasnell
approved these changes
Lxxyx
approved these changes
juanarbol
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you! Nice catch! 🎉
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
HarshithaKP
approved these changes
lpinca
approved these changes
RaisinTen
pushed a commit
that referenced
this pull request
#36952 added the `base64url` encoding option. Easier to just remove the count of options so it doesn’t need to be updated to four, five, etc. in the future. PR-URL: #37102 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
targos
pushed a commit
that referenced
this pull request
#36952 added the `base64url` encoding option. Easier to just remove the count of options so it doesn’t need to be updated to four, five, etc. in the future. PR-URL: #37102 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
#36952 added the `base64url` encoding option. Easier to just remove the count of options so it doesn’t need to be updated to four, five, etc. in the future. PR-URL: #37102 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
author ready
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 10 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |