GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: added context around the TODO change by yashLadha · Pull Request #37140 · nodejs/node

Conversation

@yashLadha

@yashLadha yashLadha commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

Added more context around the TODO change required for achieving the
task. When destructuring the isolate and environment_vars from the
environment object, it is leading to recursive dependency and thus not
able to refactor it in a better way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2021
@yashLadha

yashLadha commented Jan 30, 2021

Copy link
Copy Markdown
Contributor Author

If needed I can work on refactoring it to reduce the recursion but effort vs impact seems odd.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 requested a review from joyeecheung January 30, 2021 09:43
joyeecheung
joyeecheung approved these changes Jan 31, 2021
View reviewed changes
PoojaDurgad
PoojaDurgad reviewed Feb 1, 2021
View reviewed changes
Comment thread src/env.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha
yashLadha force-pushed the chore_minor_comment_addition branch 2 times, most recently from c05c74f to 78f142a Compare February 2, 2021 16:01
@yashLadha
yashLadha requested a review from PoojaDurgad February 2, 2021 22:56
PoojaDurgad
PoojaDurgad approved these changes Feb 3, 2021
View reviewed changes
Trott
Trott approved these changes Feb 6, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35983/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha @Trott
src: add context for TODO comment in env.cc
d6e9446 
Add more context around the TODO change required for achieving the
task. When destructuring the isolate and environment_vars from the
environment object, it is leading to recursive dependency and thus not
able to refactor it in a better way.

PR-URL: nodejs#37140
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Trott force-pushed the chore_minor_comment_addition branch from 78f142a to d6e9446 Compare February 6, 2021 22:37
@Trott
Trott merged commit d6e9446 into nodejs:master Feb 6, 2021
@Trott

Trott commented Feb 6, 2021

Copy link
Copy Markdown
Member

Landed in d6e9446
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@yashLadha @danielleadams
src: add context for TODO comment in env.cc
a6053dc 
Add more context around the TODO change required for achieving the
task. When destructuring the isolate and environment_vars from the
environment object, it is leading to recursive dependency and thus not
able to refactor it in a better way.

PR-URL: #37140
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
@todo todo Bot mentioned this pull request Feb 18, 2021
[pull] master from nodejs:master daddyfatstacksBIG/node#1160
Merged
@targos targos added the backport-blocked-v14.x label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
+1 more reviewer
@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@yashLadha @nodejs-github-bot @Trott @joyeecheung @PoojaDurgad @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.