GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix 404 links in module.md by aduh95 · Pull Request #37202 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

Currently the docs show links for all the available docs it has:

image

But the page is actually available only on v12 and v14+.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
doc: fix 404 links in module.md
0362cc3
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem. labels Feb 3, 2021
Lxxyx
Lxxyx approved these changes Feb 3, 2021
View reviewed changes
@Lxxyx Lxxyx added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Feb 3, 2021
@Lxxyx

Lxxyx commented Feb 3, 2021

Copy link
Copy Markdown
Member

fast track?
benjamingr, BethGriggs, Lxxyx, and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Feb 3, 2021
View reviewed changes
BethGriggs
BethGriggs approved these changes Feb 3, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 3, 2021
View reviewed changes
@Lxxyx

Lxxyx commented Feb 3, 2021

Copy link
Copy Markdown
Member

Cancel Ci running for macOS because it is always pending
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx

Lxxyx commented Feb 3, 2021

Copy link
Copy Markdown
Member

Landed in 3b40893
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx Lxxyx closed this Feb 3, 2021
Lxxyx pushed a commit that referenced this pull request Feb 3, 2021
@aduh95 @Lxxyx
doc: fix 404 links in module.md
3b40893 
PR-URL: #37202
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95
aduh95 deleted the module.md-introduction branch February 3, 2021 13:08
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@aduh95 @danielleadams
doc: fix 404 links in module.md
ff02e5e 
PR-URL: #37202
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
doc: fix 404 links in module.md
ad80e3d 
PR-URL: #37202
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@aduh95 @Lxxyx @benjamingr @BethGriggs @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.