GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix pr-url for DEP0148 by aduh95 · Pull Request #37205 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Feb 3, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Was pointing to #35746 instead of #35747.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Feb 3, 2021
@nodejs-github-bot nodejs-github-bot added the deprecations Issues and PRs related to deprecations. label Feb 3, 2021
@aduh95

aduh95 commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

fast-track?
BethGriggs, PoojaDurgad, richardlau, RaisinTen, and Lxxyx reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs
BethGriggs approved these changes Feb 3, 2021
View reviewed changes
richardlau
richardlau approved these changes Feb 3, 2021
View reviewed changes
PoojaDurgad
PoojaDurgad approved these changes Feb 3, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 3, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Feb 3, 2021
View reviewed changes
jasnell
jasnell approved these changes Feb 3, 2021
View reviewed changes
@aduh95
doc: fix pr-url for DEP0148
b586c6a 
PR-URL: nodejs#37205
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95
aduh95 force-pushed the fix-pr-url-DEP0148 branch from cb9d544 to b586c6a Compare February 3, 2021 14:53
@aduh95

aduh95 commented Feb 3, 2021

Copy link
Copy Markdown
Contributor Author

Landed in b586c6a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 closed this Feb 3, 2021
@aduh95
aduh95 merged commit b586c6a into nodejs:master Feb 3, 2021
@aduh95
aduh95 deleted the fix-pr-url-DEP0148 branch February 3, 2021 14:54
@aduh95 aduh95 mentioned this pull request Feb 4, 2021
tools: add GitHub Action linter for pr-url #37221
Merged
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@aduh95 @danielleadams
doc: fix pr-url for DEP0148
3f815d9 
PR-URL: #37205
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
@targos targos added the backport-blocked-v14.x label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@aduh95 @jasnell @richardlau @BethGriggs @Lxxyx @RaisinTen @PoojaDurgad @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.