GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use sentence case in README headers by Trott · Pull Request #37251 · nodejs/node

Conversation

@Trott

@Trott Trott commented Feb 6, 2021

Copy link
Copy Markdown
Member

Comply with our docs and our style guide.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 6, 2021
lpinca
lpinca approved these changes Feb 6, 2021
View reviewed changes
bcoe
bcoe approved these changes Feb 7, 2021
View reviewed changes
marsonya
marsonya approved these changes Feb 7, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 7, 2021
View reviewed changes
@Trott
doc: use sentence case in README headers
044110e 
Comply with our docs and our style guide.

PR-URL: nodejs#37251
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@Trott
Trott force-pushed the sentence-case-readme branch from f3f11c3 to 044110e Compare February 8, 2021 17:56
@Trott

Trott commented Feb 8, 2021

Copy link
Copy Markdown
Member Author

Landed in 044110e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 044110e into nodejs:master Feb 8, 2021
@Trott
Trott deleted the sentence-case-readme branch February 8, 2021 17:56
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@Trott @danielleadams
doc: use sentence case in README headers
47c4f1f 
Comply with our docs and our style guide.

PR-URL: #37251
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: use sentence case in README headers
281d75c 
Comply with our docs and our style guide.

PR-URL: #37251
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@bcoe bcoe bcoe approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @bcoe @lpinca @marsonya @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.