GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: Corrected misnamed mention of SHASUMS256.txt in README.md by marsonya · Pull Request #37260 · nodejs/node

Conversation

@marsonya

@marsonya marsonya commented Feb 7, 2021

Copy link
Copy Markdown
Member

Corrected the SHASUMS256.txt file name in README.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@marsonya
doc: SHASUMS256.txt misnamed as SHASUM256.txt in README.md
bd97a72
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 7, 2021
@marsonya marsonya changed the title doc: SHASUMS256.txt misnamed as SHASUM256.txt in README.md doc: Corrected misnamed mention of SHASUMS256.txt in README.md Feb 7, 2021
richardlau
richardlau approved these changes Feb 7, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 7, 2021
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 7, 2021
lpinca
lpinca approved these changes Feb 7, 2021
View reviewed changes
MylesBorins
MylesBorins approved these changes Feb 7, 2021
View reviewed changes

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
BethGriggs
BethGriggs approved these changes Feb 7, 2021
View reviewed changes
Trott
Trott approved these changes Feb 9, 2021
View reviewed changes
tniessen
tniessen approved these changes Feb 9, 2021
View reviewed changes
richardlau pushed a commit that referenced this pull request Feb 9, 2021
@marsonya @richardlau
doc: fix misnamed SHASUMS256.txt name in README.md
39d4d14
PR-URL: #37260
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@richardlau

richardlau commented Feb 9, 2021

Copy link
Copy Markdown
Member

Landed in 39d4d14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau closed this Feb 9, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@marsonya @danielleadams
doc: fix misnamed SHASUMS256.txt name in README.md
85bed2e
PR-URL: #37260
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
doc: fix misnamed SHASUMS256.txt name in README.md
8c41bc9
PR-URL: #37260
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@MylesBorins MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@marsonya @richardlau @MylesBorins @Trott @lpinca @tniessen @BethGriggs @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.