GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: bump remark-present-lint-node from 2.0.0 to 2.0.1 by Trott · Pull Request #37270 · nodejs/node

Conversation

@Trott

@Trott Trott commented Feb 8, 2021

Copy link
Copy Markdown
Member

This is a prerequisite for #37259.

Please 👍 to fast-track to unblock #37259.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95, richardlau, and BethGriggs reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Feb 8, 2021
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 8, 2021
@Trott

Trott commented Feb 8, 2021

Copy link
Copy Markdown
Member Author

This change is a lint-tool-only change so I think GitHub CI is sufficient (since it runs the linter). If someone disagrees and thinks Jenkins CI is required too, please say something. Thanks.
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Feb 8, 2021
View reviewed changes
richardlau
richardlau approved these changes Feb 8, 2021
View reviewed changes
BethGriggs
BethGriggs approved these changes Feb 8, 2021
View reviewed changes
@Trott
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
72f9c53 
This is a prerequisite for nodejs#37259.

PR-URL: nodejs#37270
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@Trott
Trott force-pushed the lint-preset-2.0.1 branch from adff367 to 72f9c53 Compare February 8, 2021 12:26
@Trott

Trott commented Feb 8, 2021

Copy link
Copy Markdown
Member Author

Landed in 72f9c53"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 72f9c53 into nodejs:master Feb 8, 2021
@Trott
Trott deleted the lint-preset-2.0.1 branch February 8, 2021 12:27
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@Trott @danielleadams
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
d8d851a 
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
5afaeaf 
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
f15b11f 
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @richardlau @BethGriggs @aduh95 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.