GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix description of hasSubscribers by tniessen · Pull Request #37324 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Feb 11, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen
doc: fix description of hasSubscribers
4d657a9
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 11, 2021
cjihrig
cjihrig approved these changes Feb 11, 2021
View reviewed changes
targos
targos approved these changes Feb 11, 2021
View reviewed changes
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Feb 11, 2021
@targos

targos commented Feb 11, 2021

Copy link
Copy Markdown
Member

fast-track?
tniessen, aduh95, Lxxyx, HarshithaKP, and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Feb 11, 2021
View reviewed changes
@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 11, 2021
HarshithaKP
HarshithaKP approved these changes Feb 12, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 12, 2021
View reviewed changes
RaisinTen pushed a commit that referenced this pull request Feb 12, 2021
@tniessen @RaisinTen
doc: fix description of hasSubscribers
f2c2615 
PR-URL: #37324
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RaisinTen

RaisinTen commented Feb 12, 2021

Copy link
Copy Markdown
Member

Landed in f2c2615 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen closed this Feb 12, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@tniessen @danielleadams
doc: fix description of hasSubscribers
facf3a5 
PR-URL: #37324
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
@tniessen tniessen removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 21, 2021
@tniessen
tniessen deleted the doc-has-subscribers branch February 21, 2021 11:58
targos pushed a commit that referenced this pull request May 1, 2021
@tniessen @targos
doc: fix description of hasSubscribers
a99456c 
PR-URL: #37324
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tniessen @targos @RaisinTen @cjihrig @aduh95 @HarshithaKP @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.