GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: simplify check in child_process by RaisinTen · Pull Request #37367 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Feb 14, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen
lib: simplify check in child_process
66f1574
@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Feb 14, 2021
Lxxyx
Lxxyx approved these changes Feb 14, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36124/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx Lxxyx added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 14, 2021
marsonya
marsonya approved these changes Feb 14, 2021
View reviewed changes
jasnell
jasnell approved these changes Feb 14, 2021
View reviewed changes
aduh95
aduh95 approved these changes Feb 14, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 14, 2021 •
edited by RaisinTen
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36129/ (:heavy_check_mark:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen

RaisinTen commented Feb 16, 2021

Copy link
Copy Markdown
Member Author

Landed in 7b1770527f1e18d24193f6dd8370488f1dd2ee40
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen closed this Feb 16, 2021
@RaisinTen
RaisinTen deleted the lib/simplify-check-in-child-process branch February 16, 2021 15:12
@RaisinTen

RaisinTen commented Feb 16, 2021

Copy link
Copy Markdown
Member Author

@Lxxyx I'm sorry, I forgot to add your name to the list of reviewers in this commit! Should I amend the commit and force push?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen added a commit to RaisinTen/node that referenced this pull request Feb 16, 2021
@RaisinTen
lib: simplify check in child_process
549a11c 
PR-URL: nodejs#37367
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RaisinTen

RaisinTen commented Feb 16, 2021

Copy link
Copy Markdown
Member Author

Landed in 549a11c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@RaisinTen @danielleadams
lib: simplify check in child_process
c6198fd 
PR-URL: #37367
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Feb 16, 2021
v15.9.0 proposal #37405
Closed
v15.9.0 proposal #37406
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
lib: simplify check in child_process
fe47563 
PR-URL: #37367
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marsonya marsonya marsonya approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RaisinTen @nodejs-github-bot @jasnell @Lxxyx @aduh95 @marsonya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.