GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: clarify that async_hook callbacks cannot be async by jasnell · Pull Request #37384 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Feb 15, 2021

Copy link
Copy Markdown
Member

Clarify that the init/before/after/destroy callbacks in async_hooks cannot be async functions.

Signed-off-by: James M Snell [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell
docs: clarify that async_hook callbacks cannot be async
ab8fc67 
Signed-off-by: James M Snell <[email protected]>
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to Node.js documentation. labels Feb 15, 2021
targos
targos approved these changes Feb 15, 2021
View reviewed changes
lpinca
lpinca approved these changes Feb 15, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Feb 16, 2021
View reviewed changes
marsonya
marsonya approved these changes Feb 16, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Feb 17, 2021
View reviewed changes
@Lxxyx Lxxyx added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 17, 2021
Flarna
Flarna approved these changes Feb 17, 2021
View reviewed changes
Lxxyx pushed a commit that referenced this pull request Feb 18, 2021
@jasnell @Lxxyx
doc: clarify that async_hook callbacks cannot be async
bb35b6e 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37384
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@Lxxyx

Lxxyx commented Feb 18, 2021

Copy link
Copy Markdown
Member

Landed in 85cb9c6b5896
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lxxyx Lxxyx closed this Feb 18, 2021
@targos

targos commented Feb 18, 2021

Copy link
Copy Markdown
Member

Actually landed in bb35b6e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos reopened this Feb 18, 2021
@targos targos closed this Feb 18, 2021
@Lxxyx

Lxxyx commented Feb 18, 2021

Copy link
Copy Markdown
Member

Actually landed in bb35b6e

Whoops, I forgot I manually changed the commit message, thanks for the reminder
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Feb 28, 2021
@jasnell @targos
doc: clarify that async_hook callbacks cannot be async
6675342 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37384
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@targos targos mentioned this pull request Mar 2, 2021
v15.11.0 release proposal #37569
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: clarify that async_hook callbacks cannot be async
4785755 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37384
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@marsonya marsonya marsonya approved these changes
@Flarna Flarna Flarna approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@jasnell @Lxxyx @targos @lpinca @marsonya @Flarna @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.