GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: change links to use HEAD in top level docs by mhdawson · Pull Request #37494 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Feb 23, 2021

Copy link
Copy Markdown
Member

Change the top level docs to use HEAD in links

Signed-off-by: Michael Dawson [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Githubnew-afsaneh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. labels Feb 23, 2021
aduh95
aduh95 approved these changes Feb 23, 2021
View reviewed changes
jasnell
jasnell approved these changes Feb 23, 2021
View reviewed changes
marsonya
marsonya approved these changes Feb 24, 2021
View reviewed changes
richardlau
richardlau reviewed Feb 24, 2021
View reviewed changes
Comment thread LICENSE Outdated
Comment on lines 422 to 423

@richardlau richardlau Feb 24, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two come from upstream ICU’s LICENSE (

node/deps/icu-small/LICENSE

Lines 288 to 289 in 80098e6

# Dictionary: https://github.com/veer66/lao-dictionary/blob/master/Lao-Dictionary.txt
# License: https://github.com/veer66/lao-dictionary/blob/master/Lao-Dictionary-LICENSE.txt
) so will get overwritten the next time tools/license-builder.sh is run to regenerate the LICENSE.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhdawson mhdawson Feb 26, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks good catch. I'm not sure how I included those as I was not planning any changes in files within dependencies.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Trott
Trott approved these changes Feb 24, 2021
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with LICENSE file changes removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
RaisinTen
RaisinTen approved these changes Feb 27, 2021
View reviewed changes
@mhdawson @Trott
doc: change links to use HEAD in top level docs
7a4c2c8 
Change the top level docs to use HEAD in links

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#37494
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@Trott
Trott force-pushed the next branch from 21212d1 to 7a4c2c8 Compare February 27, 2021 20:04
@Trott
Trott merged commit 7a4c2c8 into nodejs:master Feb 27, 2021
@Trott

Trott commented Feb 27, 2021

Copy link
Copy Markdown
Member

Landed in 7a4c2c8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Feb 28, 2021
@mhdawson @targos
doc: change links to use HEAD in top level docs
46af567 
Change the top level docs to use HEAD in links

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #37494
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Mar 2, 2021
v15.11.0 release proposal #37569
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@mhdawson @targos
doc: change links to use HEAD in top level docs
1b85146 
Change the top level docs to use HEAD in links

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #37494
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau left review comments
@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mhdawson @Trott @jasnell @richardlau @aduh95 @marsonya @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.