GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add url.resolve replacement example by aduh95 · Pull Request #37501 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

Fixes: #37492

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. url Issues and PRs related to the legacy built-in url module. labels Feb 24, 2021
@aduh95 aduh95 mentioned this pull request Feb 24, 2021
Please un-deprecate url.resolve #37492
Closed
marsonya
marsonya approved these changes Feb 24, 2021
View reviewed changes
jasnell
jasnell approved these changes Feb 24, 2021
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 24, 2021
RaisinTen
RaisinTen approved these changes Feb 25, 2021
View reviewed changes
@aduh95
doc: add url.resolve replacement example
5d240c5 
Fixes: nodejs#37492

PR-URL: nodejs#37501
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95
aduh95 force-pushed the url-resolve-whatwg branch from 5bddf51 to 5d240c5 Compare February 26, 2021 15:35
@aduh95
aduh95 merged commit 5d240c5 into nodejs:master Feb 26, 2021
@aduh95

aduh95 commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 5d240c5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the url-resolve-whatwg branch February 26, 2021 15:36
targos pushed a commit that referenced this pull request Feb 28, 2021
@aduh95 @targos
doc: add url.resolve replacement example
0fac27d 
Fixes: #37492

PR-URL: #37501
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Mar 2, 2021
v15.11.0 release proposal #37569
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
doc: add url.resolve replacement example
ff1990c 
Fixes: #37492

PR-URL: #37501
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please un-deprecate url.resolve

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @jasnell @marsonya @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.