GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls by Trott · Pull Request #37533 · nodejs/node

Conversation

@Trott

@Trott Trott commented Feb 27, 2021

Copy link
Copy Markdown
Member

The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Feb 27, 2021
cjihrig
cjihrig approved these changes Feb 27, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36393/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Feb 27, 2021
View reviewed changes
jasnell
jasnell approved these changes Mar 1, 2021
View reviewed changes
@Trott
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
2748b0a 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: nodejs#30845

PR-URL: nodejs#37533
Fixes: nodejs#30845
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Trott force-pushed the remove-from-status branch from 76427a4 to 2748b0a Compare March 1, 2021 20:20
@Trott

Trott commented Mar 1, 2021

Copy link
Copy Markdown
Member Author

Landed in 2748b0a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 2748b0a into nodejs:master Mar 1, 2021
@Trott
Trott deleted the remove-from-status branch March 1, 2021 20:20
targos pushed a commit that referenced this pull request Mar 2, 2021
@Trott @targos
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
9696cf7 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

PR-URL: #37533
Fixes: #30845
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 2, 2021
v15.11.0 release proposal #37569
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
097f638 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

PR-URL: #37533
Fixes: #30845
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test parallel/test-http2-multistream-destroy-on-read-tls

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.