GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — worker: allow BroadcastChannel in receiveMessageOnPort by addaleax · Pull Request #37535 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Feb 27, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell and bricss reacted with hooray emoji bricss reacted with heart emoji
All reactions
  • 🎉 2 reactions
  • ❤️ 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to the worker_threads module and Worker API. labels Feb 27, 2021
@addaleax
worker: allow BroadcastChannel in receiveMessageOnPort
3499ea6
@addaleax
addaleax force-pushed the receive-message-bc branch from f902b97 to 3499ea6 Compare February 27, 2021 17:31
cjihrig
cjihrig approved these changes Feb 27, 2021
View reviewed changes
jasnell
jasnell approved these changes Feb 27, 2021
View reviewed changes
@addaleax
fixup! worker: allow BroadcastChannel in receiveMessageOnPort
285f57d
targos
targos approved these changes Feb 28, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36401/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36406/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax added a commit that referenced this pull request Mar 3, 2021
@addaleax
worker: allow BroadcastChannel in receiveMessageOnPort
9dd2f9f 
PR-URL: #37535
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@addaleax

addaleax commented Mar 3, 2021

Copy link
Copy Markdown
Member Author

Landed in 9dd2f9f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Mar 3, 2021
@addaleax
addaleax deleted the receive-message-bc branch March 3, 2021 22:23
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@addaleax @danielleadams
worker: allow BroadcastChannel in receiveMessageOnPort
f4fd3fb 
PR-URL: #37535
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
@targos targos added the backport-blocked-v14.x label May 27, 2021
@pullfrog pullfrog Bot mentioned this pull request Sep 25, 2026
feat(vite-iconify-svgmap): add in memory iconify svg sprite plugin stephansama/packages#319
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@addaleax @nodejs-github-bot @jasnell @targos @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.