GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update eslint-plugin-markdown configuration by cjihrig · Pull Request #37549 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Feb 28, 2021

Copy link
Copy Markdown
Contributor

The first commit is the ESLint v7.21.0 update from #37546 and can be ignored here.

The second commit updates the linting setup to work with [email protected]. This also allows the update-eslint script to continue to function properly without changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 28, 2021
lpinca
lpinca approved these changes Feb 28, 2021
View reviewed changes
@aduh95

aduh95 commented Feb 28, 2021

Copy link
Copy Markdown
Contributor

I have a concurrent PR for this (#37311), but we can land this one first as mine tries to change a few things in the linter config.
cjihrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36408/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36415/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Mar 1, 2021
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 1, 2021
Trott
Trott approved these changes Mar 1, 2021
View reviewed changes
@lpinca lpinca mentioned this pull request Mar 2, 2021
tools: make update-eslint.sh work with npm@7 #37566
Closed
@cjihrig
tools: update eslint-plugin-markdown configuration
934d3f0 
This commit updates the linting setup to work with
[email protected]. This also allows the update-eslint
script to continue to function properly without changes.

PR-URL: nodejs#37549
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig
cjihrig force-pushed the markdown-plugin branch from 52c141d to 934d3f0 Compare March 3, 2021 17:43
@cjihrig
cjihrig merged commit 934d3f0 into nodejs:master Mar 3, 2021
@cjihrig
cjihrig deleted the markdown-plugin branch March 3, 2021 17:45
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@cjihrig @danielleadams
tools: update eslint-plugin-markdown configuration
25a5f0b 
This commit updates the linting setup to work with
[email protected]. This also allows the update-eslint
script to continue to function properly without changes.

PR-URL: #37549
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
@targos targos added backport-blocked-v14.x and removed backport-blocked-v14.x labels May 30, 2021
targos pushed a commit that referenced this pull request May 30, 2021
@cjihrig @targos
tools: update eslint-plugin-markdown configuration
b0cd7b2 
This commit updates the linting setup to work with
[email protected]. This also allows the update-eslint
script to continue to function properly without changes.

PR-URL: #37549
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@cjihrig @targos
tools: update eslint-plugin-markdown configuration
7eaa281 
This commit updates the linting setup to work with
[email protected]. This also allows the update-eslint
script to continue to function properly without changes.

PR-URL: #37549
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@cjihrig @targos
tools: update eslint-plugin-markdown configuration
34871ba 
This commit updates the linting setup to work with
[email protected]. This also allows the update-eslint
script to continue to function properly without changes.

PR-URL: #37549
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@cjihrig @targos
tools: update eslint-plugin-markdown configuration
2463bd0 
This commit updates the linting setup to work with
[email protected]. This also allows the update-eslint
script to continue to function properly without changes.

PR-URL: #37549
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cjihrig @aduh95 @nodejs-github-bot @Trott @lpinca @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.