GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: document that NODE_EXTRA_CA_CERTS is read only once by jasnell · Pull Request #37562 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Mar 1, 2021

Copy link
Copy Markdown
Member

Fixes: #20432

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jasnell
doc: document that NODE_EXTRA_CA_CERTS is read only once
1269400 
Fixes: nodejs#20432
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 1, 2021
mhdawson
mhdawson approved these changes Mar 1, 2021
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as documenting current behavior

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
richardlau
richardlau approved these changes Mar 1, 2021
View reviewed changes
lpinca
lpinca approved these changes Mar 2, 2021
View reviewed changes
@jasnell

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
Member Author

Landed in 9c1274a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Mar 5, 2021
jasnell added a commit that referenced this pull request Mar 5, 2021
@jasnell
doc: document that NODE_EXTRA_CA_CERTS is read only once
9c1274a 
Fixes: #20432

PR-URL: #37562
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@jasnell @danielleadams
doc: document that NODE_EXTRA_CA_CERTS is read only once
267bbe3 
Fixes: #20432

PR-URL: #37562
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: document that NODE_EXTRA_CA_CERTS is read only once
c21731b 
Fixes: #20432

PR-URL: #37562
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NODE_EXTRA_CA_CERTS cannot be set in code or relative

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jasnell @lpinca @richardlau @mhdawson @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.