GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: add error formatting support by devsnek · Pull Request #37598 · nodejs/node

Conversation

devsnek commented Mar 4, 2021

Copy link

Copy Markdown

Member

This enables the use of format strings in our native error functions. It also includes some light usage in ModuleWrap.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci PRs that need a full CI run. labels

Mar 4, 2021

devsnek force-pushed the better-native-errors branch from 79a1cce to db938cf Compare

March 4, 2021 04:29

RaisinTen reviewed

Mar 4, 2021

View reviewed changes

Comment thread

src/node_errors.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

devsnek force-pushed the better-native-errors branch from db938cf to caaffe6 Compare

March 5, 2021 17:10

devsnek requested review from RaisinTen and addaleax

March 5, 2021 17:11

devsnek force-pushed the better-native-errors branch from caaffe6 to 21b4ee7 Compare

March 5, 2021 17:28

jasnell approved these changes

Mar 5, 2021

View reviewed changes

addaleax approved these changes

Mar 5, 2021

View reviewed changes

addaleax left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot commented Mar 5, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36495/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 5, 2021

RaisinTen approved these changes

Mar 6, 2021

View reviewed changes

nodejs-github-bot commented Mar 6, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36512/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Mar 6, 2021

Copy link

Copy Markdown

Member

Does this need a documentation update (for the error code) ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 6, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36523/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax mentioned this pull request

Mar 8, 2021

crypto: add internal error codes #37650

Merged

devsnek force-pushed the better-native-errors branch from 21b4ee7 to 4434596 Compare

March 9, 2021 00:07

nodejs-github-bot commented Mar 9, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36555/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

devsnek requested a review from targos

March 9, 2021 00:09

targos approved these changes

Mar 9, 2021

View reviewed changes

devsnek commented Mar 9, 2021

Copy link

Copy Markdown

Member Author

Is "rebuild" or "retry" the correct button for just doing the failed runners

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Mar 9, 2021

Copy link

Copy Markdown

Member

The correct button is "Resume build"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

devsnek commented Mar 9, 2021

Copy link

Copy Markdown

Member Author

Close enough 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 9, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36564/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          src: add error formatting support

853086f

PR-URL: nodejs#37598
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

devsnek force-pushed the better-native-errors branch from 4434596 to 853086f Compare

March 9, 2021 16:14

devsnek merged commit 853086f into nodejs:master

Mar 9, 2021

devsnek commented Mar 9, 2021

Copy link

Copy Markdown

Member Author

landed in 853086f

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

devsnek deleted the better-native-errors branch

March 9, 2021 16:15

danielleadams pushed a commit that referenced this pull request

Mar 16, 2021


          src: add error formatting support

d59c6de

PR-URL: #37598
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

danielleadams mentioned this pull request

Mar 16, 2021

v15.12.0 proposal #37766

Merged

targos pushed a commit that referenced this pull request

May 1, 2021


          src: add error formatting support

fc0d6e4

PR-URL: #37598
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

danielleadams mentioned this pull request

May 3, 2021

v14.17.0 proposal #38507

Merged

legendecas mentioned this pull request

Oct 16, 2024

Not fully linked vm.Module throws errors from C++ when instantiated #18571

Closed

Reviewers

jasnell

jasnell approved these changes

addaleax

addaleax approved these changes

RaisinTen

RaisinTen approved these changes

+1 more reviewer

targos

targos approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.