GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: check version number in YAML comments from changelogs by aduh95 · Pull Request #37599 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

Refs: nodejs/remark-preset-lint-node#172

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. labels Mar 4, 2021
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 4, 2021
RaisinTen
RaisinTen approved these changes Mar 4, 2021
View reviewed changes
RaisinTen
RaisinTen reviewed Mar 4, 2021
View reviewed changes
Comment thread tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 4, 2021
Trott
Trott approved these changes Mar 4, 2021
View reviewed changes
@aduh95
aduh95 force-pushed the lint-version-from-changelogs branch from a5dbc78 to a49d403 Compare March 5, 2021 11:05
jasnell
jasnell approved these changes Mar 5, 2021
View reviewed changes
@jasnell

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
Member

fast-track?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Mar 5, 2021
@aduh95
tools: check version number in YAML comments from changelogs
8de1e19 
PR-URL: nodejs#37599
Refs: nodejs/remark-preset-lint-node#172
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95
aduh95 force-pushed the lint-version-from-changelogs branch from a49d403 to 8de1e19 Compare March 6, 2021 17:47
@aduh95
aduh95 merged commit 8de1e19 into nodejs:master Mar 6, 2021
@aduh95

aduh95 commented Mar 6, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 8de1e19
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the lint-version-from-changelogs branch March 6, 2021 17:48
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
tools: check version number in YAML comments from changelogs
ec71a0f 
PR-URL: #37599
Refs: nodejs/remark-preset-lint-node#172
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
@targos targos added dont-land-on-v12.x labels May 1, 2021
@targos targos mentioned this pull request May 1, 2021
[v14.x] deps: update ICU to 69.1 #38497
Closed
@targos

targos commented May 1, 2021

Copy link
Copy Markdown
Member

marked dont-land-on LTS branches because we don't backport changelog updates
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes
@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@aduh95 @jasnell @targos @Trott @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.