GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove FLAKY status for test-async-hooks-http-parser-destroy by Trott · Pull Request #37636 · nodejs/node

Conversation

@Trott

@Trott Trott commented Mar 6, 2021

Copy link
Copy Markdown
Member

This CI test failure hasn't been reported for some time.

Closes: #26610

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Mar 6, 2021
@nodejs-github-bot

nodejs-github-bot commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36516/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Mar 6, 2021
View reviewed changes
marsonya
marsonya approved these changes Mar 6, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Mar 6, 2021
View reviewed changes
@PoojaDurgad PoojaDurgad added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 8, 2021
@Trott
test: remove FLAKY status for test-async-hooks-http-parser-destroy
20009d7 
This CI test failure hasn't been reported for some time.

Closes: nodejs#26610

PR-URL: nodejs#37636
Fixes: nodejs#26610
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Trott force-pushed the async-status branch from 0301d3b to 20009d7 Compare March 8, 2021 17:39
@Trott
Trott merged commit 20009d7 into nodejs:master Mar 8, 2021
@Trott

Trott commented Mar 8, 2021

Copy link
Copy Markdown
Member Author

Landed in 20009d7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the async-status branch March 8, 2021 17:39
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@Trott @danielleadams
test: remove FLAKY status for test-async-hooks-http-parser-destroy
1f63418 
This CI test failure hasn't been reported for some time.

Closes: #26610

PR-URL: #37636
Fixes: #26610
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: remove FLAKY status for test-async-hooks-http-parser-destroy
376fcc7 
This CI test failure hasn't been reported for some time.

Closes: #26610

PR-URL: #37636
Fixes: #26610
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@marsonya marsonya marsonya approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky: parallel/test-async-hooks-http-parser-destroy.js

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @nodejs-github-bot @targos @cjihrig @marsonya @PoojaDurgad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.