GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use sentence case in README.md headers by marsonya · Pull Request #37645 · nodejs/node

Conversation

@marsonya

@marsonya marsonya commented Mar 6, 2021

Copy link
Copy Markdown
Member

changes as per doc styling guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Mar 6, 2021
@marsonya marsonya changed the title doc: apply use sentence case in README.md headers doc: use sentence case in README.md headers Mar 6, 2021
@marsonya

marsonya commented Mar 6, 2021

Copy link
Copy Markdown
Member Author

Committed with incorrect message initially.
Commit message now stands amended.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Mar 7, 2021
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Mar 8, 2021
View reviewed changes
aduh95
aduh95 approved these changes Mar 8, 2021
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 8, 2021
RaisinTen
RaisinTen approved these changes Mar 8, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Mar 8, 2021
View reviewed changes
trivikr
trivikr approved these changes Mar 12, 2021
View reviewed changes
@marsonya @aduh95
doc: use sentence case in README.md headers
b10349a 
PR-URL: #37645
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@aduh95

aduh95 commented Mar 13, 2021

Copy link
Copy Markdown
Contributor

Landed in b10349a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit b10349a into nodejs:master Mar 13, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya @danielleadams
doc: use sentence case in README.md headers
4233d6c 
PR-URL: #37645
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya @danielleadams
doc: use sentence case in README.md headers
e55058f 
PR-URL: #37645
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
doc: use sentence case in README.md headers
3a6e405 
PR-URL: #37645
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@aduh95 aduh95 aduh95 approved these changes
@trivikr trivikr trivikr approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@marsonya @aduh95 @Trott @Lxxyx @trivikr @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.