GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module: refactor NativeModule to avoid unsafe array iteration by aduh95 · Pull Request #37656 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Mar 8, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 8, 2021
RaisinTen
RaisinTen approved these changes Mar 8, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Mar 8, 2021
View reviewed changes
@Lxxyx Lxxyx added author ready PRs with CI started, the required approvals, and no outstanding review comments. module Issues and PRs related to the module subsystem. and removed needs-ci PRs that need a full CI run. labels Mar 8, 2021
@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36535/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
module: refactor NativeModule to avoid unsafe array iteration
0ccfd7d 
PR-URL: nodejs#37656
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@aduh95
aduh95 force-pushed the module-loaders-array-iteration branch from c794620 to 0ccfd7d Compare March 13, 2021 08:57
@aduh95

aduh95 commented Mar 13, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 0ccfd7d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 0ccfd7d into nodejs:master Mar 13, 2021
@aduh95
aduh95 deleted the module-loaders-array-iteration branch March 13, 2021 08:58
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
module: refactor NativeModule to avoid unsafe array iteration
bb1967c 
PR-URL: #37656
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
module: refactor NativeModule to avoid unsafe array iteration
ae0e76c 
PR-URL: #37656
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
module: refactor NativeModule to avoid unsafe array iteration
b40d12a 
PR-URL: #37656
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
module: refactor NativeModule to avoid unsafe array iteration
f375ec2 
PR-URL: #37656
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
module: refactor NativeModule to avoid unsafe array iteration
0fdb5d5 
PR-URL: #37656
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @nodejs-github-bot @Lxxyx @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.