GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove unnecessary V8 flag by aduh95 · Pull Request #37671 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

I'm trying to remove the flag upstream.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Mar 9, 2021
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Mar 9, 2021
@aduh95

aduh95 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

fast-track?
targos, lpinca, and devsnek reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added dont-land-on-v10.x labels Mar 9, 2021
targos
targos approved these changes Mar 9, 2021
View reviewed changes
@aduh95 aduh95 mentioned this pull request Mar 9, 2021
test: remove unnecessary V8 flag v8/node#123
Closed
4 tasks
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Mar 9, 2021
lpinca
lpinca approved these changes Mar 9, 2021
View reviewed changes
devsnek
devsnek approved these changes Mar 9, 2021
View reviewed changes
@aduh95
test: remove unnecessary V8 flag
5247dc0 
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: nodejs#37671
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@aduh95
aduh95 force-pushed the weak-ref-harmony branch from 2080989 to 5247dc0 Compare March 9, 2021 15:21
@aduh95

aduh95 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 5247dc0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 5247dc0 into nodejs:master Mar 9, 2021
@aduh95
aduh95 deleted the weak-ref-harmony branch March 9, 2021 15:24
aduh95 added a commit to aduh95/node that referenced this pull request Mar 15, 2021
@aduh95
test: remove unnecessary V8 flag
98a2227 
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: nodejs#37671
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
test: remove unnecessary V8 flag
013b3ff 
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: #37671
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
test: remove unnecessary V8 flag
e299054 
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: #37671
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@aduh95 aduh95 mentioned this pull request Apr 26, 2022
src: add initial shadow realm support #42869
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+2 more reviewers
@targos targos targos approved these changes
@devsnek devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @lpinca @targos @devsnek @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.