GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: move Derek Lewis back to collaborators by DerekNonGeneric · Pull Request #37726 · nodejs/node

Conversation

@DerekNonGeneric

@DerekNonGeneric DerekNonGeneric commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514

The astronomical start of spring this year is Saturday, March 20, 2021.

Goals for the season include a more sophisticated and polished hook system (pending results of the discussion topic lead by @GeoffreyBooth) for custom loader use (as well as addressing the outstanding bugs in https://github.com/nodejs/modules).

/cc @Trott to check

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell and ChALkeR reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Mar 12, 2021
targos
targos approved these changes Mar 12, 2021
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 reacted with hooray emoji DerekNonGeneric reacted with heart emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
aduh95
aduh95 approved these changes Mar 12, 2021
View reviewed changes
BethGriggs
BethGriggs approved these changes Mar 12, 2021
View reviewed changes
richardlau
richardlau approved these changes Mar 12, 2021
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Mar 12, 2021
View reviewed changes
Trott
Trott approved these changes Mar 12, 2021
View reviewed changes
benjamingr
benjamingr approved these changes Mar 12, 2021
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally LGTM.

As far as I understand our process is that this is brought up to the next TSC meeting :

The TSC can remove inactive Collaborators or provide them with Emeritus status. Emeriti may request that the TSC restore them to active status.

rather than as a pull request.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjamingr

benjamingr commented Mar 12, 2021

Copy link
Copy Markdown
Member

And welcome back <3 :)
DerekNonGeneric reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Mar 12, 2021
RaisinTen
RaisinTen approved these changes Mar 12, 2021
View reviewed changes
@Trott

Trott commented Mar 12, 2021

Copy link
Copy Markdown
Member

I added the blocked label to make sure this doesn't land before TSC review. Adding the tsc-agenda label too although we may take it up in email before the next meeting rather than waiting until then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings. label Mar 12, 2021
jasnell
jasnell approved these changes Mar 12, 2021
View reviewed changes
mcollina
mcollina approved these changes Mar 12, 2021
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
marsonya
marsonya approved these changes Mar 12, 2021
View reviewed changes
mhdawson
mhdawson approved these changes Mar 12, 2021
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
GeoffreyBooth
GeoffreyBooth approved these changes Mar 12, 2021
View reviewed changes

@GeoffreyBooth GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back, and thank you! We could really use your help 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DerekNonGeneric reacted with heart emoji
All reactions
  • ❤️ 1 reaction
cjihrig
cjihrig approved these changes Mar 12, 2021
View reviewed changes
@mhdawson mhdawson mentioned this pull request Mar 15, 2021
Node.js Technical Steering Committee (TSC) Meeting 2021-03-18 nodejs/TSC#993
Closed
@DerekNonGeneric

DerekNonGeneric commented Mar 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I have converted this to a draft to ensure accuracy in timing (my exact availability may be changing) and depending on the results of the meeting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott removed the blocked PRs that are blocked by other issues or PRs. label Mar 17, 2021
ChALkeR
ChALkeR approved these changes Mar 18, 2021
View reviewed changes
tniessen
tniessen approved these changes Mar 18, 2021
View reviewed changes
@DerekNonGeneric

DerekNonGeneric commented Mar 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

The meeting results appeared positive, so I will keep this open and landable for when I return next month.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
doc: move Derek Lewis back to collaborators
e427c48 
Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514

PR-URL: #37726
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott

Trott commented Mar 20, 2021

Copy link
Copy Markdown
Member

Landed in e427c48
DerekNonGeneric reacted with thumbs up emoji richardlau and benjamingr reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit e427c48 into nodejs:master Mar 20, 2021
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@ruyadorno
doc: move Derek Lewis back to collaborators
b09d032 
Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514

PR-URL: #37726
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
v15.13.0 proposal #37977
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@targos
doc: move Derek Lewis back to collaborators
66502fc 
Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514

PR-URL: #37726
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@ChALkeR ChALkeR ChALkeR approved these changes
@jasnell jasnell jasnell approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@targos targos targos approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

18 participants

@DerekNonGeneric @benjamingr @Trott @mcollina @ChALkeR @jasnell @GeoffreyBooth @targos @cjihrig @tniessen @richardlau @gireeshpunathil @BethGriggs @mhdawson @aduh95 @marsonya @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.