GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add hints to http.request() options by lpinca · Pull Request #37745 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Mar 13, 2021

Copy link
Copy Markdown
Member

Add documentation for the hints option.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem. labels Mar 13, 2021
cjihrig
cjihrig approved these changes Mar 13, 2021
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the linter is happy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca
doc: add hints to http.request() options
1e472e9
@lpinca
lpinca force-pushed the add/hints-option branch from 90a8e17 to 1e472e9 Compare March 13, 2021 20:04
marsonya
marsonya approved these changes Mar 14, 2021
View reviewed changes
Flarna
Flarna approved these changes Mar 14, 2021
View reviewed changes
Trott
Trott approved these changes Mar 14, 2021
View reviewed changes
@PoojaDurgad PoojaDurgad added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 15, 2021
RaisinTen
RaisinTen approved these changes Mar 15, 2021
View reviewed changes
lpinca added a commit that referenced this pull request Mar 15, 2021
@lpinca
doc: add hints to http.request() options
58166ae 
PR-URL: #37745
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@lpinca

lpinca commented Mar 15, 2021

Copy link
Copy Markdown
Member Author

Landed in 58166ae.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca closed this Mar 15, 2021
@lpinca
lpinca deleted the add/hints-option branch March 15, 2021 20:16
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@lpinca @danielleadams
doc: add hints to http.request() options
fb46d03 
PR-URL: #37745
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
v15.12.0 proposal #37766
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@lpinca @danielleadams
doc: add hints to http.request() options
3710857 
PR-URL: #37745
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
@lpinca @targos
doc: add hints to http.request() options
5f2da5a 
PR-URL: #37745
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@marsonya marsonya marsonya approved these changes
@Flarna Flarna Flarna approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@lpinca @Trott @cjihrig @marsonya @Flarna @RaisinTen @nodejs-github-bot @PoojaDurgad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.