GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip some console tests on dumb terminal by AdamMajer · Pull Request #37770 · nodejs/node

Conversation

@AdamMajer

@AdamMajer AdamMajer commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

This adds two more tests to be skipped on systems with only a
dumb terminal. See PR #33165 for details.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Mar 16, 2021
richardlau
richardlau approved these changes Mar 16, 2021
View reviewed changes
marsonya
marsonya approved these changes Mar 16, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Mar 17, 2021
View reviewed changes
Trott
Trott approved these changes Mar 20, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36885/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Mar 22, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36901/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford
guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33
mhdawson
mhdawson approved these changes May 5, 2022
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 5, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 5, 2022
@nodejs-github-bot

nodejs-github-bot commented May 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43897/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43946/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 12, 2022
CI Reliability 2022-05-12 nodejs/reliability#273
Open
CI Reliability 2022-05-12 nodejs/reliability#275
Closed
CI Reliability 2022-05-13 nodejs/reliability#276
Open
CI Reliability 2022-05-14 nodejs/reliability#277
Open
CI Reliability 2022-05-15 nodejs/reliability#278
Open
CI Reliability 2022-05-16 nodejs/reliability#279
Open
CI Reliability 2022-05-17 nodejs/reliability#280
Open
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@AdamMajer @aduh95
test: skip some console tests on dumb terminal
394a0a6 
This adds two more tests to be skipped on systems with only a
dumb terminal. See nodejs#33165
for details.
@aduh95
aduh95 force-pushed the dumb-terminal-tests branch from c1ba38a to 394a0a6 Compare May 5, 2024 21:16
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 5, 2024
@nodejs-github-bot

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58969/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes May 6, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58980/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2024
@nodejs-github-bot
nodejs-github-bot merged commit f76b28f into nodejs:main May 6, 2024
@nodejs-github-bot

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in f76b28f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 8, 2024
@AdamMajer @targos
test: skip some console tests on dumb terminal
968fe6a 
This adds two more tests to be skipped on systems with only a
dumb terminal. See #33165
for details.

PR-URL: #37770
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@AdamMajer @marco-ippolito
test: skip some console tests on dumb terminal
1dce5de 
This adds two more tests to be skipped on systems with only a
dumb terminal. See #33165
for details.

PR-URL: #37770
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@AdamMajer @soophoo
test: skip some console tests on dumb terminal
efcb5dc 
This adds two more tests to be skipped on systems with only a
dumb terminal. See nodejs#33165
for details.

PR-URL: nodejs#37770
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@MoLow MoLow MoLow approved these changes
@marsonya marsonya marsonya approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@AdamMajer @nodejs-github-bot @jasnell @Trott @cjihrig @richardlau @MoLow @mhdawson @marsonya @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.