GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update gitignore for CMake by gengjiawen · Pull Request #37793 · nodejs/node

Conversation

@gengjiawen

@gengjiawen gengjiawen commented Mar 18, 2021

Copy link
Copy Markdown
Member

I have using Clion for developing Node.js for a long time. But it's quite annoying I keep the redundant files I don't have to commit. So just ignore them (please free my pain 😃 ).

Currently things look like this:
image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gengjiawen
tools: update gitignore for CMake
ae0df32
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 18, 2021
@gengjiawen
gengjiawen requested a review from targos March 18, 2021 07:05
aduh95
aduh95 approved these changes Mar 18, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Mar 18, 2021
View reviewed changes
targos
targos reviewed Mar 18, 2021
View reviewed changes
Comment thread .gitignore Resolved

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Mar 18, 2021
View reviewed changes
marsonya
marsonya approved these changes Mar 19, 2021
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 19, 2021
jasnell
jasnell approved these changes Mar 19, 2021
View reviewed changes
@gengjiawen

gengjiawen commented Mar 20, 2021

Copy link
Copy Markdown
Member Author

Landed in d08ea01
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen gengjiawen closed this Mar 20, 2021
@gengjiawen
gengjiawen deleted the cmake-ignore branch March 20, 2021 15:02
gengjiawen added a commit that referenced this pull request Mar 20, 2021
@gengjiawen
tools: update gitignore for CMake
d08ea01 
PR-URL: #37793
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@gengjiawen @ruyadorno
tools: update gitignore for CMake
b6be472 
PR-URL: #37793
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
v15.13.0 proposal #37977
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@gengjiawen @targos
tools: update gitignore for CMake
e6a7980 
PR-URL: #37793
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@bl-ue bl-ue mentioned this pull request Jun 21, 2021
CMakeLists.txt of node js nodejs/help#3421
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marsonya marsonya marsonya approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@gengjiawen @jasnell @targos @cjihrig @aduh95 @marsonya @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.