GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky test-http2-pack-end-stream-flag by jasnell · Pull Request #37814 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Mar 19, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell [email protected]
Fixes: #37639

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Mar 19, 2021
@jasnell
test: fix flaky test-http2-pack-end-stream-flag
6e9ccf6 
Signed-off-by: James M Snell <[email protected]>
Fixes: nodejs#37639
@jasnell
jasnell force-pushed the fix-flaky-test-http2-pack-end-stream-flag branch from c5a0313 to 6e9ccf6 Compare March 19, 2021 14:46
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnell
jasnell requested review from Trott and targos March 19, 2021 15:07
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Trott
Trott approved these changes Mar 19, 2021
View reviewed changes
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Mar 19, 2021
lpinca
lpinca approved these changes Mar 19, 2021
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2021 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36906/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 22, 2021

Copy link
Copy Markdown
Member Author

Landed in 978bbf9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Mar 22, 2021
jasnell added a commit that referenced this pull request Mar 22, 2021
@jasnell
test: fix flaky test-http2-pack-end-stream-flag
978bbf9 
Signed-off-by: James M Snell <[email protected]>
Fixes: #37639

PR-URL: #37814
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno

ruyadorno commented Mar 24, 2021

Copy link
Copy Markdown
Member

hi @jasnell I see this changeset doesn't land cleanly on v15.x-staging since it builds on top of #37136 which is a semver-major landing only on v16.x.

With that in mind, should we still backport this fix to v15 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 24, 2021 via email

Copy link
Copy Markdown
Member Author
No, this shouldn't need to be backported
…
On Tue, Mar 23, 2021, 18:25 Ruy Adorno ***@***.***> wrote: hi @jasnell <https://github.com/jasnell> I see this changeset doesn't land cleanly on v15.x-staging since it builds on top of #37136 <#37136> which is a semver-major landing only on v16.x. With that in mind, should we still backport this fix to v15 ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37814 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADLM6L7HSQDX75DLSKZPYLTFE5PPANCNFSM4ZO52BRQ> .
ruyadorno reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added dont-land-on-v10.x labels Mar 24, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@targos targos Awaiting requested review from targos

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test-http2-pack-end-stream-flag

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jasnell @nodejs-github-bot @ruyadorno @Trott @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.