GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use sentence-style capitlaztion in template header by Trott · Pull Request #37837 · nodejs/node

Conversation

@Trott

@Trott Trott commented Mar 20, 2021

Copy link
Copy Markdown
Member

Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

Without this change:

image

With this change::

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Mar 20, 2021
targos
targos approved these changes Mar 20, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Mar 20, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Mar 20, 2021
View reviewed changes
marsonya
marsonya approved these changes Mar 21, 2021
View reviewed changes
@Trott
doc: use sentence-style capitlaztion in template header
172a09f 
Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

PR-URL: nodejs#37837
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Trott force-pushed the level-1 branch from ce0f841 to 172a09f Compare March 22, 2021 13:58
@Trott

Trott commented Mar 22, 2021

Copy link
Copy Markdown
Member Author

Landed in 172a09f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 172a09f into nodejs:master Mar 22, 2021
@Trott
Trott deleted the level-1 branch March 22, 2021 13:59
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@Trott @ruyadorno
doc: use sentence-style capitlaztion in template header
f97a5dd 
Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

PR-URL: #37837
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
v15.13.0 proposal #37977
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: use sentence-style capitlaztion in template header
2e0266d 
Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

PR-URL: #37837
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @targos @cjihrig @marsonya @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.