GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — util: remove unreachable inspect code by Trott · Pull Request #37941 · nodejs/node

Conversation

@Trott

@Trott Trott commented Mar 27, 2021

Copy link
Copy Markdown
Member

Convert invariant from if statement to an assertion. The condition is
believed to be impossible to trigger.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Mar 27, 2021
@nodejs-github-bot

nodejs-github-bot commented Mar 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37012/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dnlup
dnlup approved these changes Mar 27, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Mar 27, 2021
View reviewed changes
jasnell
jasnell approved these changes Mar 27, 2021
View reviewed changes
@Trott
util: remove unreachable inspect code
45cdc13 
Convert invariant from if statement to an assertion. The condition is
believed to be impossible to trigger.

PR-URL: nodejs#37941
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Trott force-pushed the remove-unreachable branch from 011792d to 45cdc13 Compare March 29, 2021 04:43
@Trott
Trott merged commit 45cdc13 into nodejs:master Mar 29, 2021
@Trott

Trott commented Mar 29, 2021

Copy link
Copy Markdown
Member Author

Landed in 45cdc13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the remove-unreachable branch March 29, 2021 04:44
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Mar 29, 2021
Create a new pull request by comparing changes across javascript-indonesias/node#330
Merged
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
@Trott @ruyadorno
util: remove unreachable inspect code
76779bf 
Convert invariant from if statement to an assertion. The condition is
believed to be impossible to trigger.

PR-URL: #37941
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
@Trott @ruyadorno
util: remove unreachable inspect code
d33f446 
Convert invariant from if statement to an assertion. The condition is
believed to be impossible to trigger.

PR-URL: #37941
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
v15.13.0 proposal #37977
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
util: remove unreachable inspect code
e6c64bf 
Convert invariant from if statement to an assertion. The condition is
believed to be impossible to trigger.

PR-URL: #37941
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@dnlup dnlup dnlup approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @jasnell @cjihrig @dnlup
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.