GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools,doc: add "legacy" badge in the TOC by aduh95 · Pull Request #37949 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

preview in light mode

preview in dark mode

This also fixes a bug when the stability index is the next sibling of the heading, currently the stability badge is shown in the TOC only if there's one or two nodes between the heading and the stability index (E.G.: in https://nodejs.org/api/crypto.html, Class: Certificate doesn't have a deprecated badge).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
tools,doc: add "legacy" badge in the TOC
ec356e0
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory. labels Mar 27, 2021
addaleax
addaleax approved these changes Mar 27, 2021
View reviewed changes
marsonya
marsonya approved these changes Mar 28, 2021
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 28, 2021
lpinca
lpinca reviewed Mar 28, 2021
View reviewed changes
Comment thread tools/doc/html.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr reviewed Mar 29, 2021
View reviewed changes
Comment thread tools/doc/html.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 @trivikr @lpinca
fixup! tools,doc: add "legacy" badge in the TOC
7e1d1b0 
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Luigi Pinca <[email protected]>
Vonaras4
Vonaras4 approved these changes Mar 29, 2021
View reviewed changes
@guybedford
guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33
jasnell
jasnell approved these changes Apr 1, 2021
View reviewed changes
@jasnell

jasnell commented Apr 1, 2021

Copy link
Copy Markdown
Member

Landed in e8b1ea4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 1, 2021
jasnell pushed a commit that referenced this pull request Apr 1, 2021
@aduh95 @jasnell
tools,doc: add "legacy" badge in the TOC
e8b1ea4 
PR-URL: #37949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95
aduh95 deleted the legacy-stability-index branch April 1, 2021 19:51
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@aduh95 @MylesBorins
tools,doc: add "legacy" badge in the TOC
51e7a33 
PR-URL: #37949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
v15.14.0 proposal #38084
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
tools,doc: add "legacy" badge in the TOC
571afd3 
PR-URL: #37949
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca left review comments
@trivikr trivikr trivikr left review comments
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@marsonya marsonya marsonya approved these changes
+1 more reviewer
@Vonaras4 Vonaras4 Vonaras4 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@aduh95 @jasnell @addaleax @lpinca @trivikr @marsonya @Vonaras4 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.